Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI Framework] Simplify markup for CardGroup at the expense of added specificity in the styles. #12183

Merged

Conversation

cjcenizal
Copy link
Contributor

This will allow us to simplify the React components in #12176

CC @PopradiArpad

@cjcenizal cjcenizal added Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. chore v6.0.0 labels Jun 5, 2017
@cjcenizal cjcenizal requested a review from snide June 5, 2017 22:34
Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjcenizal cjcenizal merged commit cfe0e7b into elastic:master Jun 6, 2017
@cjcenizal cjcenizal deleted the improvement/simplify-card-component branch June 6, 2017 00:00
cjcenizal added a commit that referenced this pull request Jun 6, 2017
@cjcenizal
Copy link
Contributor Author

5.x 6482a33

PopradiArpad pushed a commit to PopradiArpad/kibana that referenced this pull request Jun 6, 2017
PopradiArpad added a commit to PopradiArpad/kibana that referenced this pull request Jun 6, 2017
PopradiArpad added a commit to PopradiArpad/kibana that referenced this pull request Jun 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. v5.5.0 v6.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants